Hi Miguel! Any news regarding the patch? Can you commit it? Looks like it doesn't break anything... ;-)
Jarek ----- Original Message ----- From: "Jaroslaw Kowalski" <[EMAIL PROTECTED]> To: "Miguel de Icaza" <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Sent: Monday, December 16, 2002 7:05 PM Subject: Re: [Mono-list] [PATCH] "protected internal" semantics > I've tried to compile the whole mcs. > Works fine, with one exception: I get like a million of warnings in > System.Windows.Forms: > > ============ > System.Windows.Forms/MonthCalendar.cs(1561) warning CS0108: The keyword new > is required on `System.Windows.Forms.MonthCalendar.MouseUp' because it hides > `Control.MouseUp' > ============ > > but old mcs also used to produce these warnings. > > As for the regression tests all is ok, but: > > Running test-69 ... > ** (../mcs/mcs.exe:22083): WARNING **: cant resolve internal call to > "Blah::Start_internal(intptr)" (tested without signature also) > OK > > But I hope this is normal. Can you commit my patch? > > Jarek > ----- Original Message ----- > From: "Miguel de Icaza" <[EMAIL PROTECTED]> > To: "Jaroslaw Kowalski" <[EMAIL PROTECTED]> > Cc: <[EMAIL PROTECTED]> > Sent: Sunday, December 15, 2002 11:20 PM > Subject: Re: [Mono-list] [PATCH] "protected internal" semantics > > > > Hello! > > > > > Yes, the patch is supposed to make MCS more compliant with CSC's > behaviour > > > by disallowing some invalid code to compile and preventing some invalid > > > error message. > > > > > > After patch a1.cs and b1.cs should fail to compile while a0.cs and b0.cs > > > should compile just fine. > > > > Thanks for the explanation, it was not entirely clear to me, when I saw > > the errors coming up, and I figured `oh, this is buggy too' ;-) > > > > > I hope that the patch doesn't break any existing code ;-) > > > > Can I ask you something? Could you please try a full test, do it like > > this: > > > > cd mcs; > > make clean > > make > > > > Wait until the whole thing builds. If there are no errors, lets move on > > to the regression tests: > > > > cd tests > > make test-compiler-mono > > > > That will save me some time, and I have to go shopping right now ;-) > > Miguel > > > > _______________________________________________ > > Mono-list maillist - [EMAIL PROTECTED] > > http://lists.ximian.com/mailman/listinfo/mono-list > > > > > _______________________________________________ > Mono-list maillist - [EMAIL PROTECTED] > http://lists.ximian.com/mailman/listinfo/mono-list > _______________________________________________ Mono-list maillist - [EMAIL PROTECTED] http://lists.ximian.com/mailman/listinfo/mono-list
