Author: alanmc
Date: 2007-05-24 07:02:59 -0400 (Thu, 24 May 2007)
New Revision: 77903
Modified:
trunk/Mono.Nat/Messages/uPnPMessages/Requests/GetGenericPortMappingEntry.cs
trunk/Mono.Nat/UpnpNatDevice.cs
Log:
Removed some old warnings
Modified:
trunk/Mono.Nat/Messages/uPnPMessages/Requests/GetGenericPortMappingEntry.cs
===================================================================
--- trunk/Mono.Nat/Messages/uPnPMessages/Requests/GetGenericPortMappingEntry.cs
2007-05-24 11:02:40 UTC (rev 77902)
+++ trunk/Mono.Nat/Messages/uPnPMessages/Requests/GetGenericPortMappingEntry.cs
2007-05-24 11:02:59 UTC (rev 77903)
@@ -14,6 +14,7 @@
{
this.index = index;
}
+
public override System.Net.WebRequest Encode()
{
StringBuilder sb = new StringBuilder(128);
Modified: trunk/Mono.Nat/UpnpNatDevice.cs
===================================================================
--- trunk/Mono.Nat/UpnpNatDevice.cs 2007-05-24 11:02:40 UTC (rev 77902)
+++ trunk/Mono.Nat/UpnpNatDevice.cs 2007-05-24 11:02:59 UTC (rev 77903)
@@ -569,9 +569,8 @@
Stream s = response.GetResponseStream();
if (response.StatusCode != HttpStatusCode.OK)
- {
-#warning Handle this how exactly?
- }
+ return; // FIXME: This the best thing to do??
+
while (true)
{
bytesRead = s.Read(buffer, 0, buffer.Length);
@@ -621,7 +620,7 @@
}
catch (WebException)
{
-#warning At the moment i just drop the connection. Should i retry once more?
+ // Just drop the connection, FIXME: Should i retry?
}
finally
{
_______________________________________________
Mono-patches maillist - [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches
