Author: robertj
Date: 2007-10-21 07:59:00 -0400 (Sun, 21 Oct 2007)
New Revision: 87865
Modified:
trunk/mcs/class/System/System.Net.Sockets/ChangeLog
trunk/mcs/class/System/System.Net.Sockets/Socket.cs
trunk/mcs/class/System/Test/System.Net.Sockets/ChangeLog
trunk/mcs/class/System/Test/System.Net.Sockets/SocketTest.cs
Log:
In System.Net.Sockets:
2007-10-21 Robert Jordan <[EMAIL PROTECTED]>
* Socket.cs: Remove GetHashCode override from the NET_2_0
profile. Add LAMESPEC comment. Fixes bug #325113.
In Test/System.Net.Sockets:
2007-10-21 Robert Jordan <[EMAIL PROTECTED]>
* SocketTest.cs: Enable GetHashCodeTest.
Modified: trunk/mcs/class/System/System.Net.Sockets/ChangeLog
===================================================================
--- trunk/mcs/class/System/System.Net.Sockets/ChangeLog 2007-10-21 09:46:50 UTC
(rev 87864)
+++ trunk/mcs/class/System/System.Net.Sockets/ChangeLog 2007-10-21 11:59:00 UTC
(rev 87865)
@@ -1,3 +1,8 @@
+2007-10-21 Robert Jordan <[EMAIL PROTECTED]>
+
+ * Socket.cs: Remove GetHashCode override from the NET_2_0
+ profile. Add LAMESPEC comment. Fixes bug #325113.
+
2007-09-22 Gert Driesen <[EMAIL PROTECTED]>
* Socket.cs: Removed unused method.
Modified: trunk/mcs/class/System/System.Net.Sockets/Socket.cs
===================================================================
--- trunk/mcs/class/System/System.Net.Sockets/Socket.cs 2007-10-21 09:46:50 UTC
(rev 87864)
+++ trunk/mcs/class/System/System.Net.Sockets/Socket.cs 2007-10-21 11:59:00 UTC
(rev 87865)
@@ -3238,10 +3238,16 @@
throw new SocketException (error);
}
+#if ONLY_1_1
public override int GetHashCode ()
{
+ // LAMESPEC:
+ // The socket is not suitable to serve as a hash code,
+ // because it will change during its lifetime, but
+ // this is how MS.NET 1.1 implemented this method.
return (int) socket;
}
+#endif
protected virtual void Dispose (bool explicitDisposing)
{
Modified: trunk/mcs/class/System/Test/System.Net.Sockets/ChangeLog
===================================================================
--- trunk/mcs/class/System/Test/System.Net.Sockets/ChangeLog 2007-10-21
09:46:50 UTC (rev 87864)
+++ trunk/mcs/class/System/Test/System.Net.Sockets/ChangeLog 2007-10-21
11:59:00 UTC (rev 87865)
@@ -1,3 +1,7 @@
+2007-10-21 Robert Jordan <[EMAIL PROTECTED]>
+
+ * SocketTest.cs: Enable GetHashCodeTest.
+
2007-08-15 Gert Driesen <[EMAIL PROTECTED]>
* SocketTest.cs: Improved EndConnect test. Added test for bug #82446,
Modified: trunk/mcs/class/System/Test/System.Net.Sockets/SocketTest.cs
===================================================================
--- trunk/mcs/class/System/Test/System.Net.Sockets/SocketTest.cs
2007-10-21 09:46:50 UTC (rev 87864)
+++ trunk/mcs/class/System/Test/System.Net.Sockets/SocketTest.cs
2007-10-21 11:59:00 UTC (rev 87865)
@@ -502,9 +502,6 @@
}
[Test]
-#if NET_2_0
- [Category ("NotWorking")] // bug #82446
-#endif
public void GetHashCodeTest ()
{
Socket server = new Socket (AddressFamily.InterNetwork,
_______________________________________________
Mono-patches maillist - [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches
