Author: suresh
Date: 2005-03-08 03:38:20 -0500 (Tue, 08 Mar 2005)
New Revision: 41552
Modified:
trunk/mcs/class/System.Data/System.Data.ProviderBase/ChangeLog
trunk/mcs/class/System.Data/System.Data.ProviderBase/DbCommandBase.cs
trunk/mcs/class/System.Data/System.Data.ProviderBase/DbConnectionBase.cs
trunk/mcs/class/System.Data/System.Data.ProviderBase/DbDataReaderBase.cs
trunk/mcs/class/System.Data/System.Data.ProviderBase/DbParameterBase.cs
trunk/mcs/class/System.Data/System.Data.ProviderBase/DbParameterCollectionBase.cs
trunk/mcs/class/System.Data/System.Data.SqlClient/ChangeLog
trunk/mcs/class/System.Data/System.Data.SqlClient/SqlDataReader.cs
Log:
In System.Data.ProviderBase:
2005-03-08 Sureshkumar T <[EMAIL PROTECTED]>
* DbParameterBase.cs: Implemented most of get set methods.
* DbConnectionBase.cs: Commented ConnectionOptions creation,
because it is not yet implemented.
* DbCommandBase.cs: Implemented ExecuteScalar method.
* DbParameterCollectionBase.cs: Implemented Add method.
* DbDataReaderBase.cs: removed internal constructor DbDataReader
(DbCommand).
In System.Data.SqlClient:
2005-03-08 Sureshkumar T <[EMAIL PROTECTED]>
* SqlDataReader.cs: Call base constructor with CommandBehavior
parameter instead of passing DbCommand object. The internal base
class with DbCommand Parameter is removed.
Modified: trunk/mcs/class/System.Data/System.Data.ProviderBase/ChangeLog
===================================================================
--- trunk/mcs/class/System.Data/System.Data.ProviderBase/ChangeLog
2005-03-08 08:38:05 UTC (rev 41551)
+++ trunk/mcs/class/System.Data/System.Data.ProviderBase/ChangeLog
2005-03-08 08:38:20 UTC (rev 41552)
@@ -1,3 +1,13 @@
+2005-03-08 Sureshkumar T <[EMAIL PROTECTED]>
+
+ * DbParameterBase.cs: Implemented most of get set methods.
+ * DbConnectionBase.cs: Commented ConnectionOptions creation,
+ because it is not yet implemented.
+ * DbCommandBase.cs: Implemented ExecuteScalar method.
+ * DbParameterCollectionBase.cs: Implemented Add method.
+ * DbDataReaderBase.cs: removed internal constructor DbDataReader
+ (DbCommand).
+
2005-03-02 Sureshkumar T <[EMAIL PROTECTED]>
* DbConnectionBase.cs: CreateDbCommand: assign connection to the
Modified: trunk/mcs/class/System.Data/System.Data.ProviderBase/DbCommandBase.cs
===================================================================
--- trunk/mcs/class/System.Data/System.Data.ProviderBase/DbCommandBase.cs
2005-03-08 08:38:05 UTC (rev 41551)
+++ trunk/mcs/class/System.Data/System.Data.ProviderBase/DbCommandBase.cs
2005-03-08 08:38:20 UTC (rev 41552)
@@ -109,10 +109,17 @@
return reader.RecordsAffected;
}
- [MonoTODO]
public override object ExecuteScalar ()
{
- throw new NotImplementedException ();
+ object val = null;
+ DbDataReader reader=ExecuteReader();
+ try {
+ if (reader.Read ())
+ val=reader[0];
+ } finally {
+ reader.Close();
+ }
+ return val;
}
[MonoTODO]
Modified:
trunk/mcs/class/System.Data/System.Data.ProviderBase/DbConnectionBase.cs
===================================================================
--- trunk/mcs/class/System.Data/System.Data.ProviderBase/DbConnectionBase.cs
2005-03-08 08:38:05 UTC (rev 41551)
+++ trunk/mcs/class/System.Data/System.Data.ProviderBase/DbConnectionBase.cs
2005-03-08 08:38:20 UTC (rev 41552)
@@ -81,11 +81,10 @@
get { return connectionOptions; }
}
- [MonoTODO]
public override string ConnectionString {
get { return connectionString; }
set {
- connectionOptions =
ConnectionFactory.CreateConnectionOptionsInternal (value);
+ //connectionOptions =
ConnectionFactory.CreateConnectionOptionsInternal (value);
connectionString = value;
}
}
Modified:
trunk/mcs/class/System.Data/System.Data.ProviderBase/DbDataReaderBase.cs
===================================================================
--- trunk/mcs/class/System.Data/System.Data.ProviderBase/DbDataReaderBase.cs
2005-03-08 08:38:05 UTC (rev 41551)
+++ trunk/mcs/class/System.Data/System.Data.ProviderBase/DbDataReaderBase.cs
2005-03-08 08:38:20 UTC (rev 41552)
@@ -52,11 +52,6 @@
this.behavior = behavior;
}
- internal DbDataReaderBase (DbCommand command)
- {
-
- }
-
#endregion // Constructors
#region Properties
Modified:
trunk/mcs/class/System.Data/System.Data.ProviderBase/DbParameterBase.cs
===================================================================
--- trunk/mcs/class/System.Data/System.Data.ProviderBase/DbParameterBase.cs
2005-03-08 08:38:05 UTC (rev 41551)
+++ trunk/mcs/class/System.Data/System.Data.ProviderBase/DbParameterBase.cs
2005-03-08 08:38:20 UTC (rev 41552)
@@ -2,11 +2,11 @@
// System.Data.ProviderBase.DbParameterBase
//
// Author:
+// Sureshkumar T ([EMAIL PROTECTED])
// Tim Coleman ([EMAIL PROTECTED])
//
// Copyright (C) Tim Coleman, 2003
//
-
//
// Copyright (C) 2004 Novell, Inc (http://www.novell.com)
//
@@ -37,6 +37,21 @@
namespace System.Data.ProviderBase {
public abstract class DbParameterBase : DbParameter
{
+
+ #region Fields
+ string _name;
+ ParameterDirection _direction = ParameterDirection.Input;
+ bool _isNullable = false;
+ int _size;
+ byte _precision;
+ byte _scale;
+ object _paramValue;
+ int _offset;
+ DataRowVersion _sourceVersion;
+ string _sourceColumn;
+
+ #endregion // Fields
+
#region Constructors
[MonoTODO]
@@ -58,64 +73,60 @@
get { throw new NotImplementedException (); }
}
- [MonoTODO]
- public override ParameterDirection Direction {
- get { throw new NotImplementedException (); }
- set { throw new NotImplementedException (); }
+ public override ParameterDirection Direction {
+ get { return _direction; }
+ set { _direction = value; }
}
- [MonoTODO]
public override bool IsNullable {
- get { throw new NotImplementedException (); }
- set { throw new NotImplementedException (); }
+ get { return _isNullable; }
+ set { _isNullable = value; }
}
- [MonoTODO]
+
public override int Offset {
- get { throw new NotImplementedException (); }
- set { throw new NotImplementedException (); }
+ get { return _offset; }
+ set { _offset = value; }
}
- [MonoTODO]
public override string ParameterName {
- get { throw new NotImplementedException (); }
- set { throw new NotImplementedException (); }
+ get { return _name; }
+ set { _name = value; }
}
- [MonoTODO]
public override byte Precision {
- get { throw new NotImplementedException (); }
- set { throw new NotImplementedException (); }
+ get { return _precision; }
+ set { _precision = value; }
+
}
- [MonoTODO]
public override byte Scale {
- get { throw new NotImplementedException (); }
- set { throw new NotImplementedException (); }
+ get { return _scale; }
+ set { _scale = value; }
+
}
- [MonoTODO]
public override int Size {
- get { throw new NotImplementedException (); }
- set { throw new NotImplementedException (); }
+ get { return _size; }
+ set { _size = value; }
}
- [MonoTODO]
+
public override string SourceColumn {
- get { throw new NotImplementedException (); }
- set { throw new NotImplementedException (); }
+ get { return _sourceColumn; }
+ set { _sourceColumn = value; }
}
- [MonoTODO]
+
public override DataRowVersion SourceVersion {
- get { throw new NotImplementedException (); }
- set { throw new NotImplementedException (); }
+ get { return _sourceVersion; }
+ set { _sourceVersion = value; }
}
- [MonoTODO]
+
public override object Value {
- get { throw new NotImplementedException (); }
- set { throw new NotImplementedException (); }
+ get { return _paramValue; }
+ set { _paramValue = value; }
}
#endregion // Properties
Modified:
trunk/mcs/class/System.Data/System.Data.ProviderBase/DbParameterCollectionBase.cs
===================================================================
---
trunk/mcs/class/System.Data/System.Data.ProviderBase/DbParameterCollectionBase.cs
2005-03-08 08:38:05 UTC (rev 41551)
+++
trunk/mcs/class/System.Data/System.Data.ProviderBase/DbParameterCollectionBase.cs
2005-03-08 08:38:20 UTC (rev 41552)
@@ -87,11 +87,10 @@
#region Methods
- [MonoTODO]
public override int Add (object value)
{
ValidateType (value);
- throw new NotImplementedException ();
+ return list.Add (value);
}
public override void AddRange (Array values)
Modified: trunk/mcs/class/System.Data/System.Data.SqlClient/ChangeLog
===================================================================
--- trunk/mcs/class/System.Data/System.Data.SqlClient/ChangeLog 2005-03-08
08:38:05 UTC (rev 41551)
+++ trunk/mcs/class/System.Data/System.Data.SqlClient/ChangeLog 2005-03-08
08:38:20 UTC (rev 41552)
@@ -1,3 +1,9 @@
+2005-03-08 Sureshkumar T <[EMAIL PROTECTED]>
+
+ * SqlDataReader.cs: Call base constructor with CommandBehavior
+ parameter instead of passing DbCommand object. The internal base
+ class with DbCommand Parameter is removed.
+
2005-03-07 Sureshkumar T <[EMAIL PROTECTED]>
* SqlCommand.cs : Set CommandBehavior on
Modified: trunk/mcs/class/System.Data/System.Data.SqlClient/SqlDataReader.cs
===================================================================
--- trunk/mcs/class/System.Data/System.Data.SqlClient/SqlDataReader.cs
2005-03-08 08:38:05 UTC (rev 41551)
+++ trunk/mcs/class/System.Data/System.Data.SqlClient/SqlDataReader.cs
2005-03-08 08:38:20 UTC (rev 41552)
@@ -75,7 +75,7 @@
internal SqlDataReader (SqlCommand command)
#if NET_2_0
- : base ((DbCommand) command)
+ : base (command.CommandBehavior)
#endif // NET_2_0
{
readResult = false;
_______________________________________________
Mono-patches maillist - [email protected]
http://lists.ximian.com/mailman/listinfo/mono-patches