El dl 05 de 09 del 2005 a les 10:09 +0200, en/na Pedro Martínez Juliá va escriure: > Hi, > > I sent a mail with references about DataGridView, Peter told me to wait > until Jordi Mas could review my code and tell me if I can commit it. I > didn't get any response, have you got any problem with it? Should I do > something before commit?
Pedro, Your work looks good. Today is my first day of work on a few days because I have been on holidays. I'm having problems with my Mono installation and I cannot run your code right now. >From what I have seen from the code, there are these main areas that have to be improved before committing: a) It's very important to implement clipping specially for controls like Datagrid that can be very large on the screen. It reduces flickering and increases speed dramatically. b) You should handle scroll using XplatUI.ScrollWindow instead of Invalidating the whole paint area every time. I'm sure that your control flickers a lot right now when scrolled and also it's slow when scrolling. c) It seems that keyboard navigation is not implemented. This is important to implement. I recommend you to use Win32 when implementing a) and b) since the Linux layer that supports clipping (libgdiplus) and gcrolling (XplatX11) is still a work in progress. Tell me if you need help. Thanks for your work. Regards, Jordi, -- Jordi Mas i Hernàndez - Mono development team - http://www.mono-project.com Homepage and LiveJournal at http://www.softcatala.org/~jmas _______________________________________________ Mono-winforms-list maillist - [email protected] http://lists.ximian.com/mailman/listinfo/mono-winforms-list
