The issues with this approach are that: - It increases the burden of maintenance to have twice as many files with each class split into two. - It destroys the history of all of our files, so we can no longer use git blame to see who wrote stuff. - Anyone attempting to commit to Winforms will have to test their changes on MonoMacWinForms or risk breaking MonoMacWinForms.
To clarify the goal: When a user creates a Winforms Button, do you intend to create a NSButton in the background? or will you still use Winforms button drawing code on a MonoMac "surface"? If the latter, that should be accomplished by writing a new XPlat*.cs, as that's how Winforms was designed to handle multiple backends. Jonathan On 12/30/2010 1:39 PM, James Clancey wrote: > Thats correct. Right now the project is still in the beginning stages. > And depending on what is decided about here changes the the direction of > this project. But the end goal is something that could eventually be > merged in with the mono trunk. > > Here is a link to the current project. > https://github.com/Clancey/MonoMac.Windows.Form > > <https://github.com/Clancey/MonoMac.Windows.Form>Thanks, > > James Clancey > > On Thu, Dec 30, 2010 at 10:34 AM, Jonathan Pobst <[email protected] > <mailto:[email protected]>> wrote: > > I'm afraid I still don't understand what you are trying to do. > > Are you trying to use the Winforms API with a MonoMac backend? > > Jonathan > > > > On 12/30/2010 1:32 PM, James Clancey wrote: > > The end goal would be all of it. For now 75%-90% > > On Thu, Dec 30, 2010 at 10:31 AM, Jonathan Pobst > <[email protected] <mailto:[email protected]> > <mailto:[email protected] <mailto:[email protected]>>> wrote: > > What parts/how much of Winforms do you intend to use? > > On the surface, this seems like a bad idea. But maybe > that's just > cause I don't have any details. > > Jonathan > > > > On 12/30/2010 12:42 PM, James Clancey wrote: > > Hello Everyone, > > I am currently working on a Monomac project that will be > using a > good > portion of the Winforms code base. I have spoken with > miguel and we > have decided to go through the current Winform code and > split > the class > files into multiple files. The main class will hold non > ui specific > code. Since the winforms code uses xplat I am creating > a new > .xplat.cs > file and moving the xplat code there. Here is the > current diff > for what > I have done so far. > > https://github.com/Clancey/mono/commit/7bde46f1dac6549c091e978f2f294edc8ca10cb1.diff > > > Please reply back if you have any > questions/concerns/comments. > > Thanks, > > James Clancey > > > > _______________________________________________ > Mono-winforms-list maillist - > [email protected] > <mailto:[email protected]> > <mailto:[email protected] > <mailto:[email protected]>> > > http://lists.ximian.com/mailman/listinfo/mono-winforms-list > > > > > _______________________________________________ Mono-winforms-list maillist - [email protected] http://lists.ximian.com/mailman/listinfo/mono-winforms-list
