Thanks Jonathan, done. :) https://github.com/mono/mono/commit/ea9864ac6c2aef8db79cf583a526e6a0d1960256
----- Mail Original ----- De: "Jonathan Pobst" <[email protected]> À: [email protected] Cc: "Andy Hume" <[email protected]>, "mono-winforms-list" <[email protected]> Envoyé: Mardi 25 Janvier 2011 22:32:36 GMT +01:00 Amsterdam / Berlin / Berne / Rome / Stockholm / Vienne Objet: Re: [Mono-winforms-list] Removing the IDeviceContext.cs file Sounds fine to remove it. Yes, remove the file from disk and the .sources file should be fine. Thanks! Jonathan On 1/25/2011 3:22 PM, [email protected] wrote: > Hi Andy, > > Thanks for the answer. > I think it was just some kind of internal class to replicate the behavior of > the Drawing.IDeviceContext one, but since Drawing.IDeviceContext didn't exist > in .NET 1.1, it was done internally in System.Windows.Forms, without exposing > the class. That way, more code could be shared between 1.1 and 2.0, using 2 > different classes as if it was the same one. > > I think we want to remove it, can't see why we'd want to keep it. > > Do you know if the only file reference I need to remove is in the > System.Windows.Forms.dll.sources file, as I suspect? Just making sure I don't > break anything. > > ----- Mail Original ----- > De: "Andy Hume"<[email protected]> > À: "mono-winforms-list"<[email protected]> > Cc: [email protected] > Envoyé: Mardi 25 Janvier 2011 21:46:03 GMT +01:00 Amsterdam / Berlin / Berne > / Rome / Stockholm / Vienne > Objet: RE: [Mono-winforms-list] Removing the IDeviceContext.cs file > > Don't know anthing about it really. Just to note that the one in > System.Drawing is official > (http://msdn.microsoft.com/en-us/library/system.drawing.idevicecontext.a > spx) and is an interface. This one is a *class* matching -- but *not* > "implementing" -- that interface... George Giolfan who worked on > theming support is the only committer in SVN/GIT. Presumably it's > obsolete -- and maybe was never used in production. Perhaps it was used > for diagnostics purposes or something. > > Jonathan might know know more, or ask George -- though presumably not at > the wonky email address listed in that file. > > Andy > > >> -----Original Message----- >> From: [email protected] >> [mailto:[email protected]] On >> Behalf Of [email protected] >> Sent: 20 January 2011 22:41 >> To: mono-winforms-list >> Cc: Miguel de Icaza >> Subject: [Mono-winforms-list] Removing the IDeviceContext.cs file >> >> Hi guys, >> >> As I was cleaning up WinForms from .NET 1.1 code, I stumbled >> on the IDeviceContext.cs file (in the System.Windows.Forms >> namespace). I'm not sure what this class was for exactly >> (some kind of replacement for the class of the same name in >> the System.Drawing namespace, I take it), but it now seems >> useless, since it's wrapped inside a #if !NET_2_0 condition. >> >> Also, from what I understand, if I remove it, I should also >> remove it from the System.Windows.Forms.dll.sources file (if >> I'm not mistaken, that's what the make command uses to find >> classes it should build), and I think that's it. Nothing else >> to update. >> >> Am I right, and can I go ahead with this? >> >> Thanks. >> _______________________________________________ >> Mono-winforms-list maillist - [email protected] >> http://lists.ximian.com/mailman/listinfo/mono-winforms-list > > _______________________________________________ > Mono-winforms-list maillist - [email protected] > http://lists.ximian.com/mailman/listinfo/mono-winforms-list _______________________________________________ Mono-winforms-list maillist - [email protected] http://lists.ximian.com/mailman/listinfo/mono-winforms-list
