On Wed, 2007-10-24 at 11:21 -0700, Nathaniel Smith wrote: > On Wed, Oct 24, 2007 at 10:52:27AM +0200, Julio M. Merino Vidal wrote: > Can you demonstrate the existence of any user that actually wants "di" > to mean "disapprove"? > > > (Of course, one'd argue that checkout already has a shortened 'co' > > version, but that's not strictly a prefix of it...) > > See also "mv", "rm", "ci", "ls". And we've gotten bug reports when > "up" accidentally stopped meaning "update", and I'm sure would > similarly if "sy" stopped meaning "sync".
Given that nobody has spoken up about wanting di to mean disapprove, can this patch be accepted? If the answer is no, that's fine, but so far I haven't see a hard answer either way and don't want it lost in limbo. I've attached the patch again for convenience. Richard
#
# old_revision [bafa42c3132df6f967a530aacb2f71283b08baae]
#
# patch "cmd_diff_log.cc"
# from [bd55c33e185979f03a6e5fe2d32188fac1dc0676]
# to [bbf2af5a995bb7f6ea1422db33e29628bcfb71fc]
#
# patch "tests/command_completion/__driver__.lua"
# from [99783bc246436c70cd35e25536511b2233c97c6c]
# to [f9866a1c0279d56b0811f47ed0fdb77640c106d7]
#
============================================================
--- cmd_diff_log.cc bd55c33e185979f03a6e5fe2d32188fac1dc0676
+++ cmd_diff_log.cc bbf2af5a995bb7f6ea1422db33e29628bcfb71fc
@@ -474,7 +474,7 @@ prepare_diff(cset & included,
revheader = header.str();
}
-CMD(diff, "diff", "", CMD_REF(informative), N_("[PATH]..."),
+CMD(diff, "diff", "di", CMD_REF(informative), N_("[PATH]..."),
N_("Shows current differences"),
N_("Compares the current tree with the files in the repository and "
"prints the differences on the standard output.\n"
============================================================
--- tests/command_completion/__driver__.lua 99783bc246436c70cd35e25536511b2233c97c6c
+++ tests/command_completion/__driver__.lua f9866a1c0279d56b0811f47ed0fdb77640c106d7
@@ -9,7 +9,8 @@ check(mtn("dif"), 0, false, false)
-- Completion of a command.
check(mtn("diff"), 0, false, false)
check(mtn("dif"), 0, false, false)
-check(mtn("di"), 1, false, false)
+check(mtn("di"), 0, false, false)
+check(mtn("d"), 1, false, false)
-- Completion of a subcommand at the second level.
check(mtn("list", "key"), 0, false, false)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Monotone-devel mailing list [email protected] http://lists.nongnu.org/mailman/listinfo/monotone-devel
