Maybe what we should do is believe isatty() if it returns true, but check TERM if it returns false? I can think of situations where that would break something, but I think they would be rarer than now.
On Thu, Aug 6, 2009 at 9:37 AM, Diego Nieto Cid<[email protected]> wrote: > 2009/8/6 Thomas Keller <[email protected]>: >> Stephen Leake schrieb: >> >> As far as I can see in win32/terminal.cc to get --ticker=count by >> default the environment variable TERM must be set to something other >> than "" or "dumb". I have no windows box available, but maybe somebody >> else with such a box could improve the detection code there? >> > > Oh, I see. There's a comment > > // Win32 consoles are weird; cmd.exe does not set TERM, but isatty returns > // true, Cygwin and MinGW MSYS shells set a TERM but isatty returns false. > // Let's just check for some obvious dumb terminals, and default to smart. > > The unexpected behaviour of isatty seems to be a pretty old issue due > to bash actually running on a pipe. > > http://osdir.com/ml/gnu.mingw.msys/2002-10/msg00008.html : >> It's because of rxvt pty communcating to bash tty. I.E.: Through rxvt >> bash stdio is not interactive. > > cmd may be fixed by instructing it to set the TERM environment > variable during monotone setup. This can be acomplished by changing > the AutoRun[1] registry setting to something like "set TERM=cmd". > > That would break front-ends' instances started from a command shell. > However, that should be something rare on windows world. > > Other than "setting stdin to a pipe", what are front-ends required to > do for triggering "dumb mode"? i.e. do they have to set TERM to dumb? > > --- > > [1] http://technet.microsoft.com/en-us/library/cc779439%28WS.10%29.aspx > > > _______________________________________________ > Monotone-devel mailing list > [email protected] > http://lists.nongnu.org/mailman/listinfo/monotone-devel > _______________________________________________ Monotone-devel mailing list [email protected] http://lists.nongnu.org/mailman/listinfo/monotone-devel
