Am 05.06.10 01:26, schrieb Zack Weinberg: > On Fri, Jun 4, 2010 at 3:53 PM, Thomas Keller <m...@thomaskeller.biz> wrote: >> >> So, what should we do here? The addition of -E for all other unices >> would mean that we'd tamper the test. > > I distinctly remember having to add -E on SunOS, and I would not be at > all surprised if, well, anyone else who doesn't use GNU patch had the > same behavior. > > Therefore I think we should unconditionally add -E. > >> (change a test diff to use /dev/nul instead of >> /dev/nul, f.e., to see the effect - the file is no longer removed on >> "compliant" systems). > > I assume you meant "/dev/nul instead of /dev/null" there?
No, I meant /dev/nul - try GNU patch and tamper the patch file to "+++ /dev/nul" (which is of course wrong) - then you'll see that empty files are kept and are only removed explicitely with -E. This is what I mean - we'd tamper the test if we add -E, because then we just test GNU patch to correctly interpret the -E option, but not to automatically remove the file if it is empty _and_ has the target /dev/null. > By the way, standard English is "e.g." not "f.e." It expands to > "exempli gratia". Yes, that's Latin. I blame the French. I remember somebody has told me that a couple of years ago (was it you?) - I forget it from time to time - I should remember it now for the next couple of months, though :) Thomas. -- GPG-Key 0x160D1092 | tommyd3...@jabber.ccc.de | http://thomaskeller.biz Please note that according to the EU law on data retention, information on every electronic information exchange might be retained for a period of six months or longer: http://www.vorratsdatenspeicherung.de/?lang=en
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Monotone-devel mailing list Monotone-devel@nongnu.org http://lists.nongnu.org/mailman/listinfo/monotone-devel