Hey Oliver, On Tue, Apr 21, 2009 at 3:36 AM, Oliver Gorwits <oliver.gorw...@oucs.ox.ac.uk> wrote: > I'd be grateful if you could take a quick look, and let me know (on > or off list) of anything missing or incorrect that could be improved > upon, or new features to be included:
* I'm not sure that $coderef is useful doc for "around". How about $next_method? * "dump" is not an exported function, it's a method in Moose::Object. * For is => rw/ro, perhaps instead of "forget", "exclude"? It's perfectly valid to not use "is". * required doesn't imply a value being passed through a constructor (e.g. with default). Perhaps "This attribute must always have a value." * The description of reader/writer/clearer makes it sounds like the user must define them. They are provided by Moose, you just need to tell Moose which name you want. Same with accessor. * builder: "Better [than default] for subclassing" * Some new types: RoleName under Str, Maybe[TypeName] * The idiomatic check of value's class has improved to: class_type 'SomeClass' * Please remove my MooseX::Singleton from the choice related modules :) * Some newer worthy MooseX modules: MooseX::Declare, MooseX::StrictConstructor, MooseX::ClassAttribute, MooseX::Role::Parameterized Shawn
