On Jun 26, 2009, at 5:06 PM, Dave Rolsky wrote:
On Fri, 26 Jun 2009, Hans Dieter Pearcey wrote:
The attribute_helpers branch is done and ready to merge. Can
someone please
review it? (Shawn, this probably means you at least.)
Here's some initial TODOs:
* POD docs for every method provided. Some providers have docs, some
don't.
* Rename Moose::AttributeHelpers::Trait::Base to something else,
it's not a base class any more.
* POD style varies from the Moose standard. For methods, it's:
=item B<< $object->method($arg1, $arg2) >>
* Should any methods in ::Base actually be public? I suspect not.
No, I doubt they should at all.
* Add a note in the Moose::AttributeHelpers docs that this used to
MX::AH?
* I just took a look at Bag for the first time, and it's not a bag,
it's a CountingHash (CounterHash, HashCounter?). A bag is a multi-
set (like a set, but allows dupes). Now is a good time to rename it.
I think that Bag and Counter should be left off the cored version. The
cored version should only be "native" perl types and not others. We
can make a MX::AH::Extensions or something. Which brings me to the
next point, which is that we should rename this. AttributeHelpers was
a bad name and this is the perfect time to rename it. I don't really
have a good suggestion for a name right now, but something involving
"Native" and "Delegation" would work for me.
Thoughts?
- Stevan
