valid points.. but one of the nice things about the interface of highlight
is the second parameter is optional. How do you handle that in a clean way?
On Wed, Oct 1, 2008 at 3:20 PM, Guillermo Rauch <[EMAIL PROTECTED]> wrote:
> On Wed, Oct 1, 2008 at 4:16 PM, Nathan White <[EMAIL PROTECTED]>wrote:
>
>> My opinion would be no.
>>
>> 1. What is highlighting? If I think about it with a highlighter, all I am
>> doing is changing the background color.
>>
> You can highlight the font color, the border, the background. I don't see
> why it should only be the latter.
>
>
>>
>> 2. It would break how this.retrieve('hightlight:original'); is used within
>> the highlight method.
>>
> All you have to do is append :property to the storage key to handle
> multiple ones.
>
>
>>
>> If you really need more flexibility why not implement your own?
>>
> The idea is that ::highlight should be flexible enough already. Why would I
> rewrite the entire method, just to add a parameter?
>
> --
> Guillermo Rauch
> http://devthought.com
>
