Already created a ticket (actually two tickets). But I'm not sure what the fix should be because after some debugging I see that getScrolls behaves different in 1.3 than 1.2, thus breaking the functionality of toElementCenter and possibly more. It boils down that getScrolls now uses this.parentNode (see https://github.com/mootools/mootools-core/commit/6c9fda19070de685ebbbe71dd2128fe28f13f6ee).
It leaves us with some options like fix toElementCenter or revert getScrolls. But I cannot see the consequences of these actions so I hope you guys jump in on this. Ticket toElementCenter: https://mootools.lighthouseapp.com/projects/24057-mootoolsmore/tickets/538-toelementcenter-scrolls-to-incorrect-position. Ticket getScrolls: https://mootools.lighthouseapp.com/projects/2706-mootools/tickets/1192-getscrolls-is-different-in-13-and-breaks-toelementcenter. On 14 mrt, 19:56, Aaron Newton <[email protected]> wrote: > Most of this thread needs to move to lighthouse. I can do that for you, but > then you won't get emails as we work on it. Would you care to open a ticket? > You can also create a pull request on github and send us the fix, which > makes us love you even more. > > On Tue, Mar 8, 2011 at 1:35 AM, woomla <[email protected]> wrote: > > After some puzzling I believe that the function to calculate the new > > scroll position needs to add scroll[axis] to it. So that line becomes: > > to[axis] = scroll[axis] + position[axis] - (containerSize[axis] - > > size[axis]) / 2; > > > This seems to work perfectly for me, at least for the vertical > > scrolling that I tested. See > > >http://jsfiddle.net/woomla/D2nJJ/8/ > > > The first two time it uses the mootools function. The second time the > > element is scrolled out of view. > > The third and forth time it uses the altered function. The third time > > it centers the element. The forth time the element stays centered. > > > On Mar 6, 11:05 pm, woomla <[email protected]> wrote: > > > Thanks. > > > > And what happens if we center the element twice? > > > >http://jsfiddle.net/D2nJJ/6/ > > > > On 4 mrt, 16:18, Ryan Florence <[email protected]> wrote: > > > > > I didn't bother interpreting your example but made this example > > instead. > > > > >http://jsfiddle.net/rpflorence/D2nJJ/ > > > > > This appears to work as expected. It scrolls one element to the center > > of another element. > > > > > On Mar 4, 2011, at 1:57 AM, woomla wrote: > > > > > > Hi, > > > > > > I've created a large list of div's in a container div. I want the > > > > > container to scroll programmatically to some element. So I suppose to > > > > > use toElementCenter. But it appears that the calculation is wrong, or > > > > > my interpretation of the function is wrong. I hope someone can > > clarify > > > > > this for me. > > > > > > See this fiddle:http://jsfiddle.net/CB7Xj/17/ > > > > > > The first few functions create the list and put the items in a > > results > > > > > array. At the bottom of the script we start to scroll to all elements > > > > > one by one with function mooScrollTo. In the output you see some > > > > > scrolling, but at some point it is going up and down again.
