On Fri, Jul 15, 2011 at 7:54 AM, 3dolab <[email protected]> wrote:

> Hello, you probably already know MooTabs
> http://mootools.net/forge/p/mootabs


Nope.


I've successfully tested it with MooTools 1.3 and tried to add some
> features, such as the 'loop' and 'totalTabs' options. I'm proud of the
> result http://github.com/3dolab/MooTabs
>
> However, ideas and tips are welcome, since I'd still like to:
>
> 1- Chain subsequent clicks on next/prev button, animation is actually
> overlapping
> 2- Stop the default onmousedown event. Don't know why, but 'stop()'
>

I don't believe you need to do "new Event(e).stop()" - I believe MT takes
care of creating a MT event before passed to your callback function. Just
do:

e.stop();

And I'm not sure you want "this.stop()" - I'm guessing that's supposed to
reference _your_ stop method? However, your scope is wrong if that's the
intended functionality.

var self = this;
tab.addEvent('mousedown', function (e) {
    e.stop();  // Stop the default event and propogation
    self.stop();  // Stop the player
});


> seems to fail
> https://github.com/3dolab/MooTabs/blob/master/Source/mootabs-0.1.0-nc.js#L87
> 3- Merge the 'step' method into 'setupTabs'



Does that muddy things up? Happy coding.

~Philip

-- 
http://lonestarlightandsound.com/

Reply via email to