Hi,

ok, I am late on that latest change. Please remove all the
abort() statments then.

In general, it would be better to ensure that no faulty XML
is generated in the first place. Graceful decay also leads
to error that are hard to track down.

-phi

2009/10/5 "Münt, Bernd" <[email protected]>:
>> Von: [email protected] [mailto:[email protected]] Im Auftrag
>
>> if you want the decoder to just be less picky and gracefully
>> decay on faulty XML input, you can edit the source file
>> moses/src/XmlOption.cpp and remove all "return false;"
>> statements after "TRACE_ERR("ERROR:..."
>> lines.
>
> There is no "return false;".
>
> F.e. see Sentence.cpp: The code snippet is that part that causes moses to 
> abort when the xml is invalid (f.e. "<b>Test<b1>"):
>
> if (staticData.GetXmlInputType() != XmlPassThrough) {
>                if (!ProcessAndStripXMLTags(line, xmlOptionsList, 
> m_reorderingConstraint, xmlWalls )) {
>                        TRACE_ERR("Unable to parse XML in line " << line);
>                        abort();
>                }
>        }
>
> I can see a direct "abort()", but no "return false".
>
> Regards, Bernd
>
> --
> Bernd Münt               Durchwahl: 030/69032-509
> Software Developer       Zentrale:  030/69032-300
> euroscript Systems GmbH  Fax:       030/69032-505
> Alt-Moabit 91            eMail:     [email protected]
> 10559 Berlin             Web:       http://www.euroscript.de
>
>

_______________________________________________
Moses-support mailing list
[email protected]
http://mailman.mit.edu/mailman/listinfo/moses-support

Reply via email to