hi guchun
thanks for the patch, it's been committed.
https://github.com/moses-smt/mosesdecoder/commit/7073f7d89168dc14112a6fd7a34cda9efd5fd6b3
you can also do git pull requests on github to any ambiguity when
submitting patches. Or i can give you commit access to the moses
repository.
On 16/02/2012 00:40, Guchun Zhang wrote:
Hi,
It's actually the best to change from line 101 to line 118 to
*my $numStr = NumStr(0);
if (-e "$TMPDIR/extract.$numStr")
{
`$extractCmd`;
}
if (-e "$TMPDIR/extract.$numStr.inv")
{
`$extractInvCmd`;
}
if (-e "$TMPDIR/extract.$numStr.o")
{
`$extractOrderingCmd`;
}
}
else
{
if (-e "$TMPDIR/extract.0")
{
rename "$TMPDIR/extract.0", "$extract";
}
if (-e "$TMPDIR/extract.0.inv")
{
rename "$TMPDIR/extract.0.inv", "$extract.inv";
}
if (-e "$TMPDIR/extract.0.o")
{
rename "$TMPDIR/extract.0.o", "$extract.o";
}
}*
The reason is that sometimes multiple tmp directories are created such
as in the sge situation and not all the files in question are in the
same tmp directory when being combined.
Cheers,
Guchun
On 15 February 2012 12:34, Guchun Zhang <[email protected]
<mailto:[email protected]>> wrote:
Hi,
I'd like to report a little bug inside
generic/extract-parallel.perl on line 104. For the current code,
the ordering file will never be produced under the parallel
scenario as $TMPDIR/extract.0.o never exists.
It's quite straightforward to remove the bug as follows,
changing from
if (-e "$TMPDIR/extract.0.o")
to
my $numStr = NumStr(0);
if (-e "$TMPDIR/extract.$numStr.o").
Cheers,
Guchun
_______________________________________________
Moses-support mailing list
[email protected]
http://mailman.mit.edu/mailman/listinfo/moses-support
_______________________________________________
Moses-support mailing list
[email protected]
http://mailman.mit.edu/mailman/listinfo/moses-support
