Hi Hieu, ok, I will take a close look a that. Kenneth, Lane, how does this interfere with your thread-local/non-locking plans? I do not want to introduce code that you will have to remove later in order to reach your goal.
W dniu 10.09.2012 16:01, Hieu Hoang pisze: > hi marcin > > > Funnily, there is also no locking in the AlignmentInfoCollection > class itself although is uses a global static collection. But it has a > very > nice comment: "@todo Check whether this needs locking in threaded > environment" :) I'd say "Yes!". > > i added this @todo comment a few months ago but haven't gotten round to > checking it or fixing it. If you're able to fix it, that'll be great. I > think the locking in FactorCollection would be a good comparison. > > this issue is prob why the chart decoder blows up with multiple-threads > so you'll be hitting 2 birds with 1 stone with a fix > > _______________________________________________ > Moses-support mailing list > Moses-support@mit.edu > http://mailman.mit.edu/mailman/listinfo/moses-support _______________________________________________ Moses-support mailing list Moses-support@mit.edu http://mailman.mit.edu/mailman/listinfo/moses-support
