Hi, that is indeed a bug. I fixed it as you suggested.
-phi On Wed, Mar 6, 2013 at 12:05 PM, Česlav Przywara <[email protected]> wrote: > Hello, > I'm "reusing" code for smoothing from the consolidate tool in one of my > projects and I've noticed that there might be a small bug in Kneser-Ney > discounting implementation: > > if (kneserNeyFlag) { > ... > if (countEF < 2) D = kneserNey_D1; > if (countEF < 3) D = kneserNey_D2; > ... > } > > Shouldn't the second if clause rather be an else-if? > > Cheers, > Ceslav > > _______________________________________________ > Moses-support mailing list > [email protected] > http://mailman.mit.edu/mailman/listinfo/moses-support _______________________________________________ Moses-support mailing list [email protected] http://mailman.mit.edu/mailman/listinfo/moses-support
