Hi, we here in Edinburgh rarely use the GridEngine jobs submission facilities so some bitrot may have crept in. Can you send a diff of your changes, so we can check them in?
-phi On Thu, Mar 7, 2013 at 4:43 PM, Jaakko Väyrynen <[email protected]> wrote: > Hi all, > > I noticed that in experiment.perl the parameters for cluster (sge) settings > are not read properly from the configuration file. I'm using an old version > of Moses but the same code was in the online github. So I'm not able to > commit or test these suggestions. They seem to work for me. > > 1) Parameters are read but not passed along > > The function &get_qsub_args(.) reads parameter values from qsub-settings, > qsub-memory, qsub-hours and concatenates them together. However, it then > overwrites everything by the value in the parameter qsub-project. The line: > > $qsub_args = "-P $project" if defined($project); > > should be changed to string concatenation with an extra space: > > $qsub_args .= " -P $project" if defined($project); > > > 2) Parameters are read only from the current section. > > The above-mentioned parameters (other than qsub-project) are read with > &get(.), not with &backoff_and_get(.) and the parameters given in the > general section are not taken into account, for instance, in tuning. The > function should be changed unless it is a wanted feature that the qsub > parameters should be set in each section. > > > Cheers, > -jaakko > > _______________________________________________ > Moses-support mailing list > [email protected] > http://mailman.mit.edu/mailman/listinfo/moses-support > _______________________________________________ Moses-support mailing list [email protected] http://mailman.mit.edu/mailman/listinfo/moses-support
