Hi Hieu, Find the file attached.
Hope it helps ☺ Tomas From: [email protected] [mailto:[email protected]] On Behalf Of Hieu Hoang Sent: Friday, October 24, 2014 1:35 PM To: Tomas Fulajtar Cc: moses-support ([email protected]) Subject: Re: [Moses-support] Fix for make-factor-brown-cluster-mkcls.perl - encoding issue hi tomas, thanks for the bug report. You can do a git pull request. https://help.github.com/articles/using-pull-requests/ However, if it's just a small change to 1 file, then just send the changed file to me & i'll check it in for you On 24 October 2014 04:29, Tomas Fulajtar <[email protected]<mailto:[email protected]>> wrote: Hi team, I have found there is missing specification of the file mode opening in the make-factor-brown-cluster-mkcls.perl. See the read_cluster_from_mkcls function in scripts/training/wrappers/make-factor-brown-cluster-mkcls.perl file. The fix is to add the following code bellow line 36: binmode(CLUSTER_FILE, “utf8”); This resolves encoding problems when user wants to process text containing extended characters. Please let me know how can I implement the fix to github repository. Thank you, Tomas _______________________________________________ Moses-support mailing list [email protected]<mailto:[email protected]> http://mailman.mit.edu/mailman/listinfo/moses-support -- Hieu Hoang Research Associate University of Edinburgh http://www.hoang.co.uk/hieu
make-factor-brown-cluster-mkcls.perl
Description: make-factor-brown-cluster-mkcls.perl
_______________________________________________ Moses-support mailing list [email protected] http://mailman.mit.edu/mailman/listinfo/moses-support
