Performance. Actually, if I had a fast integer to string converter (with appropriate license and such), I'd add it to FakeOFStream and remove the use of std::cout. There seem to be plenty floating around on the Internet. Regardless, FakeOFStream supports Flush() so this doesn't change much other than the call.
Kenneth On 01/31/2015 07:58 PM, Tom Hoar wrote: > Thanks, Ken. > > On second thought, hold off on the request. We're updating utilities for > native Windows compatibility. We submit the changes (including > buffering) to you for review. Was there any reason specific reason you > changed the functionality from unbuffered to buffered output? > > > > > On 02/01/2015 01:17 AM, Kenneth Heafield wrote: >> Hi Tom, >> >> I can. Have you looked at the python API though? It's much cleaner >> and faster than what you're doing now. >> >> Kenneth >> >> On 01/31/2015 06:21 AM, Tom Hoar wrote: >>> The KenLM `query` utility has changed in how it pipes to stdout. I'm >>> using Python's subprocess.Popen() and stdin.write() with >>> stdout.readline(). In Release 1, the output was unbuffered and piping >>> line-by-line worked. In the newest version (RC-3), piping hangs at >>> stdout.readline() as though `query` is buffering the output. >>> >>> Is it possible to add a command line switch to disable output buffers, >>> similar to what we added to the tokenizer.perl and detokenizer.perl >>> scripts (-b)? >>> _______________________________________________ >>> Moses-support mailing list >>> [email protected] >>> http://mailman.mit.edu/mailman/listinfo/moses-support >>> >> _______________________________________________ >> Moses-support mailing list >> [email protected] >> http://mailman.mit.edu/mailman/listinfo/moses-support > > _______________________________________________ > Moses-support mailing list > [email protected] > http://mailman.mit.edu/mailman/listinfo/moses-support > _______________________________________________ Moses-support mailing list [email protected] http://mailman.mit.edu/mailman/listinfo/moses-support
