Hi Jeroen, on the matter of style I'd like to point out that the official style guidelines for Moses code require opening braces on a separate line.
http://www.statmt.org/moses/?n=Moses.CodeStyle The official style has always required this since the first entry about this in the Wiki back in 2009. Recently (Jan 16 this year) the page was vandalized by an anonymous editor to claim something to the contrary, but the page has now been restored to what it should be. So while you're fiddling with the beautify scripts, please fix this as well. I'm personally no friend of automatic "beautification", because it does far more harm than good in my opinion, but if you insist on doing it, it should be done right. Best regards - Uli On Sun, May 17, 2015 at 2:13 PM, Jeroen Vermeulen < [email protected]> wrote: > Hi all, > > We have a replacement for the old beautify.perl script: > scripts/other/beautify.py. > > It does one of two things, or both: > * Re-format C/C++ source code, just like the old script did. > * Check for style errors and such. > > This last thing is called a "lint" check. For this I chose Pocketlint, > a checker I have good experiences with, although if people want a > different one (or additional checks) I can change that. > > I fixed most of the lint that got reported, except in JavaScript code. > We may add automatic reformatting for additional languages later. I > sincerely hope all of this does not cause any serious merge problems for > your branches. > > Ideally, everyone would get in the habit of installing Pocketlint and > running this script regularly whether they accidentally added any lint. > To see how the script works, run: > > ./scripts/other/beautify.py -h > > The lint check processes a few files at a time. By default it stops > when it sees lint. If you want to see a full check, use the -i option. > > > Jeroen > _______________________________________________ > Moses-support mailing list > [email protected] > http://mailman.mit.edu/mailman/listinfo/moses-support > > -- Ulrich Germann Senior Researcher School of Informatics University of Edinburgh
_______________________________________________ Moses-support mailing list [email protected] http://mailman.mit.edu/mailman/listinfo/moses-support
