If I understand you correctly you are worrying about changing global options with XML translation requests sent to the server. This is not the case. Each request gets its own local copy of parameters at line https://github.com/moses-smt/mosesdecoder/blob/master/moses/server/TranslationRequest.cpp:276, so all parameter changes are local to the XML request being processed.
- Uli On Mon, Feb 20, 2017 at 6:39 PM, Lane Schwartz <[email protected]> wrote: > Hi, > > In moses/parameters/ReportingOptions.cpp, the following code was added by > Uli in commit 69e5a1cc152de40 about a year ago: > > > m = param.find("align"); > if (m != param.end() && Scan<bool>(xmlrpc_c::value_string(m->second))) > ReportSegmentation = 1; > > > This is relevant when using XML-RPC requests via mosesserver, and it turns > on ReportSegmentation if the XML response includes segmentation. Most of > the time this would be superfluous, since the reason that the XML response > contains segmentation is typically because ReportSegmentation was already > set to 1 in the moses server config file. > > I'm interested in re-enabling the moses server code that allows this to > alternatively be set via XML-RPC request, but I don't want > ReportSegmentation turned on in this case. The reason is that I want the > segmentation information, but I don't want the returned hypothesis to > include the segmentation in the reported hypothesis string. If > ReportSegmentation is set to 1, then that will happen. > > My question is, is it OK to delete or comment out this block of code? > > If someone has a good reason why it's there, that's fine. But I can't seem > to find one. > > Thanks, > Lane > -- Ulrich Germann Senior Researcher School of Informatics University of Edinburgh
_______________________________________________ Moses-support mailing list [email protected] http://mailman.mit.edu/mailman/listinfo/moses-support
