Hi, Thanks for your comments. I've created a pull request - do whatever you like with it ;)
For the scripts, I've been using --install-scripts to move them. This did the job, at least in my environment... Yves On 20/02/2018 12:24:25, Hieu Hoang <[email protected]> wrote: I would actually advised against using --prefix The moses scripts are written with the assumption that the directories bin scripts are side-by-side. --prefix seems to move bin, but not scripts Hieu Hoang http://moses-smt.org/ [http://moses-smt.org/] On 20 February 2018 at 09:20, Hieu Hoang <[email protected] [mailto:[email protected]]> wrote: Hieu Hoang Sent while bumping into things On 20 Feb 2018 8:25 a.m., "Yves Scherrer" <[email protected] [mailto:[email protected]]> wrote: Hi all, My first attempt at testing moses2 failed because CreateProbingPT2 could not be found... On the last line of mosesdecoder/Jamroot, is created as a symlink to CreateProbingPT, but this is done in the $(TOP)/bin directory (same for moses_chart BTW). However, $(TOP) refers to the build directory, which may differ from the final install directory, namely when --prefix is used and set to something else than the current directory. In this case, the symlinks are indeed created, but in a directory from which the executables have already been moved out of... Can somebody confirm that behavior? I'm a little surprised that this hasn't come up earlier... For me, replacing $(TOP) by $(PREFIX) in the last couple of lines of the Jamroot file did the trick both when using --prefix and when not using it, but maybe there is a better way to handle this. Do a git pull for your changes. I don't think a lot of people use --prefix so the bug was missed. Btw, you can use CreateProbingPT instead of CreateProbingPT2. The soft link was added for backyard compatibility when the two used to be different Best, Yves _______________________________________________ Moses-support mailing list [email protected] [mailto:[email protected]] http://mailman.mit.edu/mailman/listinfo/moses-support [http://mailman.mit.edu/mailman/listinfo/moses-support]
_______________________________________________ Moses-support mailing list [email protected] http://mailman.mit.edu/mailman/listinfo/moses-support
