On (05/31/16 13:51), Keith Winstein wrote: >(adding mosh-devel list) > >Thanks, Ryan. This may have come from 0eb61480 ( >https://github.com/mobile-shell/mosh/commit/0eb61480), when we made it a >fatal error if pkg-config fails to find the desired library (when adding >support for Apple Common Crypto and Nettle alongside OpenSSL). > >Perhaps we should just make it a warning...? >
Keith, As long as there is a supported way to get the old behavior (and/or disable the fatal warning), that would address our needs. I'd assume we would enable/disable this via a configure knob. -r >On Tue, May 31, 2016 at 1:02 PM, Ryan Steinmetz <z...@freebsd.org> wrote: > >> Keith, >> >> FreeBSD ships with OpenSSL, however, (as mentioned) does not provide .pc >> files. .pc files are only installed alongside the openssl/libressl >> ports. >> >> mosh's configure smarts should: >> - Look for the openssl libraries in a couple of default locations >> (/usr/lib and /usr/local/lib). >> - Should provide a --with-openssl-libs and --with-openssl-includes >> configure options. >> >> The existing configure script from mosh 1.2.5 finds the libraries fine. >> >> >> Let me know if you have any questions, thanks, >> -r >> >> ----- Forwarded message from Peter Jeremy <pe...@rulingia.com> ----- >> >> Date: Wed, 1 Jun 2016 05:57:15 +1000 >> From: Peter Jeremy <pe...@rulingia.com> >> To: z...@freebsd.org >> Subject: Fw: Re: [mosh-devel] Mosh 1.2.6 release candidate available for >> testing] >> User-Agent: Mutt/1.6.1 (2016-04-27) >> >> Sorry, I should have copied you on the attached. >> >> -- >> Peter Jeremy >> >> Date: Tue, 31 May 2016 20:45:02 +1000 >> From: Peter Jeremy <pe...@server.rulingia.com> >> To: Keith Winstein <kei...@mit.edu> >> Cc: Richard Woodbury <rpwoo...@mybox.org> >> Subject: Re: [mosh-devel] Mosh 1.2.6 release candidate available for >> testing >> User-Agent: Mutt/1.6.1 (2016-04-27) >> >> Hi Keith, >> >> On 2016-May-30 00:33:27 -0700, Keith Winstein <kei...@mit.edu> wrote: >> >>> Could you please send in some positive testing reports on the Mosh 1.2.6 >>> release candidate? >>> >> >> It won't configure with the base OpenSSL on FreeBSD 10.3 because FreeBSD >> doesn't include the pkg-config files; >> >> configure:8821: checking for CRYPTO >> configure:8828: $PKG_CONFIG --exists --print-errors "openssl" >> Package openssl was not found in the pkg-config search path. >> Perhaps you should add the directory containing `openssl.pc' >> to the PKG_CONFIG_PATH environment variable >> Package 'openssl', required by 'world', not found >> >> Possibly the port maintainer can work around that. >> >> If I install OpenSSL or LibreSSL from ports then mosh builds and works. >> I've tried 1.2.5.95rc1 as a server with both itself 1.2.4a as a client >> and don't see any obvious issues. >> >> Note that most of the self tests are skipped: >> >> make check-TESTS >> PASS: ocb-aes >> PASS: encrypt-decrypt >> PASS: base64 >> SKIP: e2e-success.test >> SKIP: e2e-failure.test >> SKIP: emulation-ascii-iso-8859.test >> SKIP: emulation-80th-column.test >> SKIP: emulation-attributes-vt100.test >> SKIP: emulation-attributes-16color.test >> SKIP: emulation-attributes-256color8.test >> SKIP: emulation-attributes-256color248.test >> SKIP: emulation-back-tab.test >> SKIP: emulation-cursor-motion.test >> SKIP: emulation-multiline-scroll.test >> SKIP: emulation-wrap-across-frames.test >> SKIP: prediction-unicode.test >> SKIP: pty-deadlock.test >> SKIP: server-network-timeout.test >> SKIP: server-signal-timeout.test >> SKIP: window-resize.test >> SKIP: unicode-combine-fallback-assert.test >> SKIP: unicode-later-combining.test >> >> -- >> Peter Jeremy >> >> >> >> >> >> >> ----- End forwarded message ----- >> >> -- >> Ryan Steinmetz >> PGP: 9079 51A3 34EF 0CD4 F228 EDC6 1EF8 BA6B D028 46D7 >> -- Ryan Steinmetz PGP: 9079 51A3 34EF 0CD4 F228 EDC6 1EF8 BA6B D028 46D7 _______________________________________________ mosh-devel mailing list mosh-devel@mit.edu http://mailman.mit.edu/mailman/listinfo/mosh-devel