Hi Carlo, I just wanted to get back to you and let you know that the failing emulation-attributes-bce test is probably an issue in tmux. We've filed https://github.com/tmux/tmux/issues/3339 with the tmux folks to get their input. It seems there was a behavior change between tmux 3.1c and 3.3a that caused the output to be visually identical, but no longer byte-identical.
Thank you so much for your report. Sincerely, -Alex On Fri, Aug 5, 2022 at 6:55 AM Carlo Cabrera <carlo.cabr...@comworks-inc.com> wrote: > > Hi Alex, > > Thanks for looking into this. I was also confused about the failure, since I'm > aware of your CI setup. The tmux tests being skipped makes sense, but it seems > making sure that they are run doesn't reproduce the failure. > > My TERM outside tmux is xterm-256color and inside tmux is tmux-256color. I use > iTerm2.app. My tmux is built from 9d9445a48e626731e9384b6b9cda367cd4cef5d3 > from > the tmux GitHub repository. I also tried with 3.3a from Homebrew, but got the > same error. In both cases, tmux is configured with `--enable-utf8proc`. > > I wonder if my tmux.conf is to blame. I'm traveling at the moment, but I'll > experiment with this when I get back. I did notice that the tests pass > `-f /dev/null` to tmux, but I wasn't able to check if that's done > consistently. > > Since this doesn't seem to be reproducible on your end, I'll try to pin this > down on my own in the meantime. However, if you still think I should open an > issue, then I'm happy to do so. > > Thanks, > Carlo > > > On 4 Aug 2022, at 21:57, Alex Chernyakhovsky <acher...@mit.edu> wrote: > > > > Hi Carlo, > > > > I attempted to reproduce your failure on my mac (macOS 12.5, tmux > > 3.2a, protobuf 2.6.1, ncurses 6.3) and was not able to: > > > > PASS: emulation-80th-column.test > > PASS: emulation-attributes-bce.test > > > > This is inside Terminal.app with TERM=xterm-256color > > > > Do you know what value of TERM you had and what version of tmux? I am > > suspicious of the tmux version right now. > > > > Sincerely, > > -Alex > > > > On Thu, Aug 4, 2022 at 9:37 AM Alex Chernyakhovsky <acher...@mit.edu> wrote: > >> > >> Hi Carlo, > >> > >> Can you file an issue on github.com/mobile-shell/mosh? I am a bit > >> surprised by this report, because we run macOS CI with homebrew's > >> packages > >> (https://github.com/mobile-shell/mosh/runs/7664363362?check_suite_focus=true > >> has the latest pass from recently), and you can see that the tests in > >> question were SKIP'd: > >> > >> SKIP: emulation-80th-column.test > >> SKIP: emulation-attributes-bce.test > >> > >> I suspect tmux is not available in macOS CI and we need to correct this. > >> > >> Sincerely, > >> -Alex > >> > >> On Thu, Aug 4, 2022 at 9:11 AM Carlo Cabrera > >> <carlo.cabr...@comworks-inc.com> wrote: > >>> > >>> Hi there, > >>> > >>> I was testing out mosh from head > >>> (fe72a3e084f0d37ee18a719f0ecde4aeb8af10e8) > >>> recently, and encountered an error with `make check`. I ran > >>> > >>> ./autogen.sh; ./configure; make check > >>> > >>> I'm running macOS 12: > >>> > >>> ❯ sw_vers > >>> ProductName: macOS > >>> ProductVersion: 12.2.1 > >>> BuildVersion: 21D62 > >>> ❯ uname -a > >>> Darwin summit.lan 21.3.0 Darwin Kernel Version 21.3.0: Wed Jan 5 > >>> 21:37:58 PST 2022; root:xnu-8019.80.24~20/RELEASE_ARM64_T8101 arm64 > >>> > >>> The tests that failed were > >>> - emulation-80th-column.test > >>> - emulation-attributes-bce.test > >>> > >>> I've attached the log for your reference. I've also attached a small > >>> patch I > >>> used to silence spurious errors about parsing the version of tmux that I > >>> have > >>> installed. > >>> > >>> I attempted to do a `git bisect`, since I distinctly recall `make check` > >>> succeeding for me from head not too long ago (i.e. in the past year), but > >>> I > >>> couldn't find a recent non-failing commit. I would guess that this > >>> failure comes > >>> from a change in one of the dependencies I'm using, but I haven't tried > >>> building with older versions yet. > >>> > >>> I built with protobuf 21.4 and ncurses 6.3, both installed with Homebrew. > >>> > >>> Let me know if you'd like to investigate further and need more > >>> information. > >>> > >>> Thanks, > >>> Carlo > >>> > >>> _______________________________________________ > >>> mosh-devel mailing list > >>> mosh-devel@mit.edu > >>> https://mailman.mit.edu/mailman/listinfo/mosh-devel > _______________________________________________ mosh-devel mailing list mosh-devel@mit.edu https://mailman.mit.edu/mailman/listinfo/mosh-devel
