Mike Belshe wrote:

> I recently ran into some similar problems with several types of ptrs in
> functionlists being bogus...
> 
> I traced it down to this little nasty in pkcs11p.h & pkcs11u.h:
> 
>     #if defined(XP_WIN)
>     #if defined(_WIN32)
>     #pragma warning(disable:4103)
>     #pragma pack(push, cryptoki, 1)
>     #endif
>     #endif
> 
> The makesystem I was using for my stuff wasn't defining "XP_WIN", so I
> didn't get the packing right and all the offsets were messed up relative to
> nss3.dll, which did define XP_WIN...
> 
> Mozilla guys- this appears to be the only reference to XP_WIN in the public
> headers for PKCS11.... any chance it can be redone as just _WIN32 but not
> XP_WIN?  That might cause other problems... who knows :-)

I have filed a bug about this.  
See http://bugzilla.mozilla.org/long_list.cgi?buglist=84584

XP_WIN is defined in secport.h, but secport.h is not #included prior to this
file in all relevant cases.  I personally think the ifdef for XP_WIN is
redundant here.

--
Nelson Bolyard               Sun / Netscape Alliance

Reply via email to