Doug Turner wrote:
> I have already made all the changes on my branch and either it was a
> trival change or the code was doing the wrong thing in the first place
> (eg. depending on the content type on the channel before any request was
> made)
hmm, after perusing your changes to the docloader/uriloader, I didn't see
the content-type negotiation layer we've been talking about. You've
basically just replaced nsIChannel args w/ nsIRequest, and have added
request->GetParent() in several places. Regarding that latter point, you're
having to do this in progress notification callbacks which adds a function
call (sometimes two if you have to get the streaminfo iface too). Adding
weight to notification callbacks isn't optimal. I haven't seen the weight of
the changes though which are pushing this api change, so we'll likely have
to live w/ it.
Above you mention that "code was doing the wrong thing in the first place."
I was expecting some of that code to be in the uri|docloader, but you didn't
make those kinds of changes in there. What code are you referring to? I'm
not convinced we're adding a content-type negotiation layer at all, thus
possibly nullifying much of my concern.
Jud
