Hi, I have a small question about some design in the gtkmozembed code.
For the LINK_MESSAGE signal
The signaling code has
mLinkMessage = aStatus;
gtk_signal_emit(GTK_OBJECT(mOwner->mOwningWidget), moz_embed_signals[LINK_MESSAGE]);
The callback sequence then subsequently executes:
if (embedPrivate->mWindow){
*getter_Copies(embedString) = NEW_TOOLKIT_STRING(embedPrivate->mWindow->mLinkMessage);
retval = strdup(embedString);
}
return retval;
Why do you not pass the link message string as an argument to the handler in the first place?
No reason, really. It is because that is how it has always been. And there's no reason to break callers at this point.
--Chris
