In article <[EMAIL PROTECTED]>, Shai Spharim
<[EMAIL PROTECTED]> wrote:
> The function nsDrawingSurfaceMac::IsOffscreen is declared and defined in
> nsDrawingSurfaceMac.h as:
>
> NS_IMETHOD IsOffscreen(PRBool *aOffScreen) {return mIsOffscreen;}
>
> This looks like a mistake, and is different from the other OS's
> nsDrawingSurfaceXYZ::IsOffscreen. *aOffScreen isn't being modified
> This looks like the proper implemantation:
>
> NS_IMETHOD nsDrawingSurfaceMac::IsOffscreen(PRBool *aOffScreen)
> {
> *aOffScreen = mIsOffscreen;
> return NS_OK;
> }
>
> What gives?
Looks like a bug to me! In fact, there are a large number of bugs in
this file, such as nsDrawingSurfaceMac::IsPixelAddressable() not setting
its out parameter, and nsDrawingSurfaceMac::GetPixelFormat() also.
Patches coming up.
- Patrick
