Simon Montagu wrote:
> 
> A word about the use of #ifdef OLDIBMBIDI, IBMBIDI_0 and other
> variants. Coders use these just as a way of commenting out blocks of
> Bidi code. They can be ignored, and should probably be removed before
> checking in the submission.

It might be nice to remove them from the patches, and resubmit the
patches (along with other changes that are made to satisfy other review
comments). Bug 62777 might get unwieldy if we add new versions of the
patches there, so maybe we should create a new bug for the new patches.

Comments?

Erik

Reply via email to