Robert O'Callahan wrote:
I'm adding a new style struct type for column style data. Does that sound like the right thing to do? They're all reset properties, as far as I can tell. Initially we will only support column-width and column-count.
When will the column structs be fetched? Would they affect frame construction?
Yes, column-count and column-width will affect frame construction for block frames (we check if they're both auto; if so, no columns will be used, otherwise we have to construct an nsColumnFrame wrapper). Other column properties will not affect frame construction.
If so, would it make sense to put them in the display struct?
I don't know, because I don't really know the style system very well, so I don't know what design hurts least. We can assume that the default values for the column properties will apply to 99.99% of frames.
A separate struct may make sense if the struct will be requested rather infrequently (eg only for nodes that have block display) or something along those lines...
Should all the column code be #ifdefed?
What would be the benefit? And would that be temporarily, or permanently?
Either. People could configure it out, and we could avoid affecting the trunk at all while the support is developed. Personally I'd rather not have #ifdefs but maybe not everyone wants to deal with it.
Rob _______________________________________________ mozilla-layout mailing list [EMAIL PROTECTED] http://mail.mozilla.org/listinfo/mozilla-layout
