Rene Pronk wrote:
My question is: are they really necessary?
As far as I can tell, probably not. They could probably be replaced by a debug-only member variable storing the last length we were grown to and some asserts that we're not accessing anything outside that length.
but I can't believe someone put them in there for no reason.
Well, they were put in for safety, I would think. But such safety is better ensured by explicit listing of constraints and assertion thereof than silently doing something not too broken in failure cases...
Please file a bug on this, cc me? If you have a patch, attach it? If you can add asserts as I described above, that would be optimal....
One approach would be to just make the memsets #ifdef DEBUG. And while we're at it, change the constant to 0xDD or so.
Rob -- Robert O'Callahan <[EMAIL PROTECTED]> http://ocallahan.org "If we claim to be without sin, we deceive ourselves and the truth is not in us. If we confess our sins, he is faithful and just and will forgive us our sins and purify us from all unrighteousness." 1 Johnn 1:8-9 _______________________________________________ mozilla-layout mailing list [EMAIL PROTECTED] http://mail.mozilla.org/listinfo/mozilla-layout
