Re: tree batching: performance fix for multiple message delete comingsoon (hyatt rocks)

[Alec Flett]

Seth Spitzer wrote:

Alec Flett wrote:

[EMAIL PROTECTED]">

Seth Spitzer wrote:




The optimization is to use the tree batching api.




why we can't sync this up with the existing RDF batching API...

basically it goes:

Deleting 5 messages:
* datasource calls: observer->beginUpdateBatch(this)
* Template Builder (an rdf observer) QI's the root (the <tree>) to some
"batchable" interface: element->QI(nsIDOMXULBatchableElement)
* Template builder now calls the tree's batchableElement->BeginBatch();

This way it would all happen automatically, and we wouldn't need any
special JS.

I thought that the batching api's in RDF just drop notifications.
 

Well, that's what they do right NOW sure :)

 
for example, nsXULTemplateBuilder::OnAssert(), if we are in a batching state, we just return
right away.  So content would not be created.  Calling EndBatch() does do anything special
to make know about assertions we ignored.

I think batching is basically broken in nsXULTemplateBuilder.

                                    Alec