(changed the things I did not commetn on. document still at http://stud4.tuwien.ac.at/~e0225227/MozillaMIMETypes.html)
Boris Zbarsky wrote:
Second, we should consider putting this on mozilla.org and linking to it (web developer docs? Mozilla developer docs? Who's the target audience here?).
The target audience is mostly web developers who wonder how Mozilla decides to handle content, I'd say.
But in fact one reason for not putting it on m.o was that I was not sure where to best put it.
III) "it is checked whether", not "it is checked if". Better yet, avoid this construct entirely for better readability (I can suggest alternative phrasings if desired).
You mean "By checking for most common HTML Tags, it is checked if the data is html content"? I could not come up with a good alternative phrasing, could you suggest one?
Oh, there was another occurence. I cahnged it to "If all else fails, the buffer (i.e. the first few bytes of the file) is searched for embedded nulls; if none are found, text/plain will be used, otherwise application/octet-stream."
IV) I believe we check for a preferences extension-to-type mapping before we ask the OS. If that's not the case, it's a bug.
Yes; reading the code, I was not sure if we did the correct thing. (I did not think of that use case when writing the code...)
Someone should check this. maybe I'll do it when I get time.
V) Does any of this code need more documentation as to its intent, in your opinion? It seems to me that the dance around "<?xml" (looking at the URI there) could use some explaining. Anything else like that?
Yeah, the <?xml probably could use some explaining. But I don't know the reasoning behing it :) Why don't we just use text/xml for it?
I added explanation for the hardcoded extension->type mapping (for speed).
VI) The "Helper Applications" section really does feel tacked on... should that be part of a separate document on what happens when Mozilla encounters a type it cannot handle internally?
Yeah... that is true... but it is a pretty short paragraph. Does it really deserve an own document?
