Re: overwritten error code in nsFtpConnectionThread

[Doug Turner]

I think that change will be okay.

Christian Biesinger wrote:

Hi,
I stumbled over this codepiece in nsFtpConnectionThread today...

// LIST
          case FTP_S_LIST:
            rv = S_list();

            if (NS_FAILED(rv))
                mInternalError = NS_ERROR_FTP_CWD;

            MoveToNextState(FTP_R_LIST);

Is there a reason mInternalError is not just set to rv?
hm... ok, it seems to often return just a generic error code. BUT, in at least one case it returns a useful error, that the user of this code might want to see - NS_ERROR_NOT_RESUMABLE, if trying to resume a directory listing...

Any opinions to changing the if into something like this:
    if (rv == NS_ERROR_NOT_RESUMABLE)
        mInternalError = rv;
    else if (NS_FAILED(rv))
        mInternalError = NS_ERROR_FTP_CWD;
?

-biesi

_______________________________________________
Mozilla-netlib mailing list
[EMAIL PROTECTED]
http://mail.mozilla.org/listinfo/mozilla-netlib