On Thu, 04 Jul 2002 00:51:11 -0500 Michael Kaply <[EMAIL PROTECTED]>
wrote:
>
> If you think any of these are wrong:
>
> http://lxr.mozilla.org/seamonkey/source/widget/src/os2/nsLookAndFeel.cpp#60
>
> By all means, please let us know
[This is based on the correlation I did between 'pmwin.h' and the
GUI in the OS/2 'Scheme Palette'. Several of the color-function-
constant names were not obvious -- I hope I got SYSCLR_WINDOW
matched correctly (as the background color in ordinary folders).]
I __do__ think two definitions (associated with 3D) are wrong:
- eColor_threedlightshadow is defined as SYSCLR_BUTTOMIDDLE
I think it should be SYSCLR_BUTTONLIGHT
- eColor_threeddarkshadow is defined as SYSCLR_BUTTONDEFAULT
I think it should be SYSCLR_BUTTONDARK
I do not know the context in which eColor_buttontext is used:
- if it is used in conjunction with eColor_menu, then its
definition is OK,
- but if it is used inside a "pushbutton", then it is possible
the user might have defined SYSCLR_BUTTONMIDDLE so as to
make eColor_buttontext (or eColor_graytext) hard to read.
(In other words, the current definition specifies
eColor_buttontext in terms of (drop-down) __menu__
colors, *not* in terms of __pushbutton__ colors.)
Finally, there is a "bells&whistles" change you might consider:
- eColor_infobackground is defined as an RGB constant
it might be defined as SYSCLR_HELPBACKGROUND
- eColor_infotext is defined as SYSCLR_WINDOWTEXT
it might be defined as SYSCLR_HELPTEXT
--------
> Mikus Grinbergs wrote:
> >
> > Gentlemen, Gentlemen !! With some three dozen OS/2 window_area
> > entries to "copy" the color_settings from, you have chosen to use
> > the setting from '3D Highlight Dark' as the color of the Mozilla
> > progress bar !!
> >
> > Who would have thought it ?
[I think the color of SYSCLR_WINDOWTEXT would be right for the
progress bar (or if you want contrast, then the color of
SYSCLR_WINDOWSTATICTEXT).]
You said that the __skin__ chooses the color. I was using the
'Classic' skin, which comes as part of the Mozilla package,
and which Mozilla installs as the *default* skin.
Would you have a source reference for me, so I can go look at
what colors the 'Classic skin' is choosing on OS/2 ?
Thanks, mikus
