On 2014/02/23 19:21, Uwe Tantz <[email protected]> wrote:
> Hi,
> here is a patch that allows for seeking in aac files.

Please split this into separate documented patches.  It is nearly
impossible to review a patch consisting of many independent changes.

For example, it is not clear why you delete the following struct, what
does this have to do with AAC seeking??

> -struct DecoderBuffer {
> -     Decoder *decoder;
> -     InputStream *is;
>  
> -     /** the allocated size of the buffer */
> -     size_t size;
> -
> -     /** the current length of the buffer */
> -     size_t length;
> -
> -     /** number of bytes already consumed at the beginning of the
> -         buffer */
> -     size_t consumed;
> -
> -     /** the actual buffer (dynamic size) */
> -     unsigned char data[sizeof(size_t)];
> -
> -     DecoderBuffer(Decoder *_decoder, InputStream &_is,
> -                   size_t _size)
> -             :decoder(_decoder), is(&_is),
> -              size(_size), length(0), consumed(0) {}
> -};

_______________________________________________
mpd-devel mailing list
[email protected]
http://mailman.blarg.de/listinfo/mpd-devel

Reply via email to