It might be worth adding a comment at that point of the header to say that these definitions are only needed for compatibility with undocumented GMP interfaces and that they shouldn't be used in MPIR itself. Otherwise we might find they become a feature we have to support in future.
Bill. On 16 March 2012 09:52, Jason <[email protected]> wrote: > On 16 March 2012 09:18, leif <[email protected]> wrote: >> Jason wrote: >>> >>> I added app tests for >>> mpfr-3.1.0 >>> mpfi-1.5.1 >>> ecm-6.4.1 >>> flint-2.3 >>> pari-2.5.1 >> >> >> [Apparently Jeroen missed this.] >> >> >> >> >>> and the first missing functions are >>> >>> ../../../mpfr-3.1.0/src/mulders.c: In function 'mpfr_divhigh_n_basecase': >>> ../../../mpfr-3.1.0/src/mulders.c:208:3: error: 'gmp_pi1_t' undeclared >>> (first use in this function) >>> ../../../mpfr-3.1.0/src/mulders.c:208:3: note: each undeclared identifier >>> is reported only once for each function it appears in >>> ../../../mpfr-3.1.0/src/mulders.c:208:14: error: expected ';' before >>> 'dinv2' >>> ../../../mpfr-3.1.0/src/mulders.c:229:3: warning: implicit declaration of >>> function 'invert_pi1' >>> ../../../mpfr-3.1.0/src/mulders.c:229:15: error: 'dinv2' undeclared (first >>> use in this function) >>> ../../../mpfr-3.1.0/src/mulders.c:244:9: warning: implicit declaration of >>> function 'udiv_qr_3by2' >>> make[2]: *** [mulders.lo] Error 1 >>> >>> I'll add the new undocumented functions this weekend to the svn for a >>> mpir-2.5.2 release in the next week or so >> >> >> >> Note that MPFR 3.1.0 builds and works well with (still) MPIR 2.1.3 in Sage, >> so these types and functions must have been removed from MPIR at some point, >> unless I'm missing something... >> > > gmp_pi1_t was not defined in MPIR 2.1.3. Perhaps someone made a patch > in Sage to fix this. > > This type is used for functions that take a precomputed inverse in > GMP. We have similar in MPIR, but the name is not the same. > > The MPFR people have been doing a great job of checking MPFR is > compatible with MPIR, so I'm not sure how this has slipped through. > Anyhow, it's easy to fix. > > Bill. > > -- > You received this message because you are subscribed to the Google Groups > "mpir-devel" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/mpir-devel?hl=en. > > > --------------------------------------------- > > I've added two macro's to the svn to get mpir to pass all the new tests , it > was only mpfr running make check that seem to require them. I'll add the GAP > tests later tonight or over the weekend. We did have similar macros with > different names but they were not identical. > > > Jason > > -- > You received this message because you are subscribed to the Google Groups > "mpir-devel" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/mpir-devel?hl=en. > -- You received this message because you are subscribed to the Google Groups "mpir-devel" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/mpir-devel?hl=en.
