Hi Brian, I have fixed the three issues you pointed out to do with building an Arb dll. Thanks very much for pointing these out.
As for the flint dll, I don't mind what name is used. It's not a problem for me. This is technically flint2, not flint. But it is very many years since anyone has used the latter. I think it is fine to simply call it flint now. Bill. On Tue, 14 Apr 2020 at 19:55, Brian Gladman <rieman...@gmail.com> wrote: > Hi Bill and Fredrik, > > Being in CORVID lockdown, I decided to have a look at building Arb with > Visual Studio. This has gone pretty well but I have a few issues on > which I would appreciate your advice. > > I can compile and build Arb as a static library without any issues but > building Arb as a DLL fails because it needs two flint export ssymbols > that are not present in the FLINT DLL. > > The first of these is '__flint_clz_tab' which I find can be switched on > in FLINT by defining NEED_CLZ_TAB when building FLINT. This should not > be a problem since I can modify my FLINT build to do this. > > The second missing symbol is 'partitions_lookup', which is defined in > the FLINT file 'number_of_partitions.c' where it does have an export > definition. But this is not visible to Arb because it this symbol is not > declared in flint.h or, as far as I can tell, in any other exported > FLINT header. > > So is this a symbol that FLINT should export and, if so, where should > the export declaration be placed? > > Another issue I am keen to tidy up is library location and naming. I am > using simple names for the mpir dependent Windows builds: mpir, mpfr, > pthreads, ... and adding extensions 'lib and .dll accordingly. > > For example, MPIR is in a root directory callled 'mpir' and within this > directory I have lib, dll, and exe sub-directories where I place the > mpir.lb, mpir.dll and mpir.exe build outputs. The same structure applies > to mpfr, pthreads but for FLINT I have been using the directory 'flint2' > rather than 'flint' and 'lib_flint.lib' and 'dll_flint.dll' for the > libraries (I am not sure why!) > > In order to get a consistent approach now that I am adding Arb, I would > like to use the directory 'flint' rather than 'flint2' as the root > directory for FLINT and use the names 'flint.lib' and 'flint.dll' for > the libraries. But before I do this I would like to know if this change > is going to cause any issues for others (I am aware the the CMake FLINT > build depends on my FLINT build, which is why I am asking). > > with my regards, > > Brian > > -- > You received this message because you are subscribed to the Google Groups > "mpir-devel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to mpir-devel+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/mpir-devel/b0d4c8ab-8f2e-b1a3-0327-72f8d9e0557a%40gmail.com > . > -- You received this message because you are subscribed to the Google Groups "mpir-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to mpir-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/mpir-devel/CAB0xFntgpVFMsyVgJNUtPS4ZjGE2eT2RuzV%3DXPWRkC0LOmtDnA%40mail.gmail.com.