Yesterday Jake Brutlag wrote: > > DS_NAM_FMT, used for data source names and DEF_NAM_FMT used for vnames > in graph arguments aren't identical. This presents a problem for > computed data sources (1.1.x), in which data source names are referenced > in rpn expressions. But valid data sources name may not meet > DEF_NAM_FMT. > > rrd_format.h:#define DS_NAM_FMT "%19[a-zA-Z0-9_-]" > > rrd_graph.h:#define DEF_NAM_FMT "%29[_A-Za-z0-9]" > > DS_NAM_FMT allows dash (hyphen) characters while DEF_NAM_FMT does not. > Would there be any objections to DEF_NAM_FMT permitting dash characters? > It is true that dash is the minus operator in rpn, but this would only > be problem if the data source name starts with a dash (which seems > unlikely).
ok, since we are allowing them in ds we might as well in def I guess ... I am happy with the change as long as you will go ahead and fix any potential fall out from this change :-) cheers tobi > > -- > Unsubscribe mailto:[EMAIL PROTECTED] > Help mailto:[EMAIL PROTECTED] > Archive http://www.ee.ethz.ch/~slist/rrd-developers > WebAdmin http://www.ee.ethz.ch/~slist/lsg2.cgi > -- ______ __ _ /_ __/_ / / (_) Oetiker @ ISG.EE, ETZ J97, ETH, CH-8092 Zurich / // _ \/ _ \/ / System Manager, Time Lord, Coder, Designer, Coach /_/ \.__/_.__/_/ http://people.ee.ethz.ch/~oetiker +41(0)1-632-5286 -- Unsubscribe mailto:[EMAIL PROTECTED] Help mailto:[EMAIL PROTECTED] Archive http://www.ee.ethz.ch/~slist/rrd-developers WebAdmin http://www.ee.ethz.ch/~slist/lsg2.cgi
