[
https://issues.apache.org/jira/browse/MRUNIT-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Donofrio updated MRUNIT-48:
-------------------------------
Attachment: MRUNIT-48-1.patch
deprecated all add/with Output/Input FromString methods
added test to confirm that using InputFromString with a mapper or reducer that
doesnt take a Text will throw a ClassCastException which is probably good enough
However, OutputFromString is confusing because the log output will print the
exact same output which isnt equal because the classes dont match. Added to
additional else if statements in TestDriver to throw/log a more meaningful
error such as "Missing expected output (a, 1): Mismatch in value class:
expected: class org.apache.hadoop.io.Text actual: class
org.apache.hadoop.io.LongWritable" instead of seeing:
Received unexpected output (a, 1)
MIssing expected output (a, 1)
Only test these cases in mrunit.TestMapDriver because all validation is done
through the common TestDriver class
After a release are we going to delete these methods, they seem to add more
confusion than they are worth?
> Test and Deprecate Driver.{*OutputFromString,*InputFromString} Methods
> ----------------------------------------------------------------------
>
> Key: MRUNIT-48
> URL: https://issues.apache.org/jira/browse/MRUNIT-48
> Project: MRUnit
> Issue Type: Improvement
> Reporter: Brock Noland
> Priority: Minor
> Fix For: 1.0.0
>
> Attachments: MRUNIT-48-1.patch
>
>
> We should test a driver that only deals with, say LongWritable, to ensure the
> runTest() method fails when we use the
> Driver.{*OutputFromString,*InputFromString} Methods.
> Additionally, I think we should deprecate these methods since they don't play
> well with our generic interfaces.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
