[
https://issues.apache.org/jira/browse/MRUNIT-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233264#comment-13233264
]
Jarek Jarcec Cecho commented on MRUNIT-68:
------------------------------------------
Thank you sir for removing the unnecessary 0 counter size check.
I actually see the "inconsistency" with renaming the method to addCounter. It
looks cleaner to me using withCounter method name. But I'm not strong on this
opinion, so really feel free to rename it.
> Support custom counter checking
> -------------------------------
>
> Key: MRUNIT-68
> URL: https://issues.apache.org/jira/browse/MRUNIT-68
> Project: MRUnit
> Issue Type: New Feature
> Affects Versions: 0.8.1
> Reporter: Jarek Jarcec Cecho
> Assignee: Jarek Jarcec Cecho
> Fix For: 1.0.0
>
> Attachments: MRUNIT-68.patch, MRUNIT-68.patch, MRUNIT-68.patch,
> MRUNIT-68.patch
>
>
> It would be great if user could check custom counter values in addition to
> checking outputs. Let me show my idea on example, right now counters needs to
> be checked explicitly:
> assertEquals(2,
> mapDriver.getCounters().findCounter(CustomMapper.CustomCounter.NAME).getValue());
> It would be great if user could do something like:
> .withCounter(CustomMapper.CustomCounter.Name, 2)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira