[
https://issues.apache.org/jira/browse/MRUNIT-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jim Donofrio updated MRUNIT-95:
-------------------------------
Description: Use Serialization framework to change all set/add input/output
methods to serialize, deserialize to do defensive copying. This will prevent
users from modifying input/expected output objects by accident. The one problem
is dealing with custom serializations that require a setting in the conf. Users
would have to make sure to set the property in the conf before adding any
input/output, this may break some existing test programs. I guess we can just
throw a meaningful exception in the add method when we cannot serialize,
deserialize. (was: Use Serialization framework to change all add input methods
to serialize, deserialize to do defensive copying into input lists. This will
prevent users from modifying input objects by accident and then having a test
fail. The one problem is ideally this defensive copying would be done when the
user calls addInput. The problem is dealing with custom serializations that
require a setting in the conf. Users would have to make sure to set the
property in the conf before adding any input, this may break some existing test
programs. I guess we can just throw a meaningful exception in the add method
when we cannot serialize, deserialize. Any thoughts?
Also deprecate and eventually remove getInputValues method in ReduceDriverBase
to prevent access to the input list.)
Summary: use Serialization framework to change all set/add input/output
methods to serialize, deserialize to do defensive copying (was: use
Serialization framework to change all add input methods to serialize,
deserialize to do defensive copying into input lists)
> use Serialization framework to change all set/add input/output methods to
> serialize, deserialize to do defensive copying
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: MRUNIT-95
> URL: https://issues.apache.org/jira/browse/MRUNIT-95
> Project: MRUnit
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Jim Donofrio
> Assignee: Jim Donofrio
> Priority: Minor
> Labels: serialization
> Fix For: 1.0.0
>
>
> Use Serialization framework to change all set/add input/output methods to
> serialize, deserialize to do defensive copying. This will prevent users from
> modifying input/expected output objects by accident. The one problem is
> dealing with custom serializations that require a setting in the conf. Users
> would have to make sure to set the property in the conf before adding any
> input/output, this may break some existing test programs. I guess we can just
> throw a meaningful exception in the add method when we cannot serialize,
> deserialize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
