Yes. There are several issues with the patch.
- pkgconfig is not available on windows
- it's not necessary to search for the ogg, vorbis etc... depending on
options at the top of the main cmake file.
- the lame problem. We just need the lame.h header. So finding the lame
include dir is enough. Maybe Cmake find_path can be used to find it nicely.
lasconic
2013/5/20 Marc Schultz <[email protected]>
> You can include it, but keep in mind that the manual path of the Homebrew
> package "lame" isn't the nice way to go. I wanted to fix this, but there
> was no time. I think we have to create a pull request for this package on
> the Homebrew-Github repo, to include pkg-config support for it.
>
>
> On Mon, May 20, 2013 at 2:46 PM, Lasconic <[email protected]> wrote:
>
>> Cool. Does that mean you are working on it? because I was starting to
>> include your past patch in the build system to move to homebrew. Maybe
>> better to not double work.
>>
>> lasconic
>>
>>
>> 2013/5/20 Marc Schultz <[email protected]>
>>
>>> Don't worry, I'm testing my changes in Linux and Windows too.
>>>
>>>
>>> On Mon, May 20, 2013 at 2:42 PM, Lasconic <[email protected]> wrote:
>>>
>>>>
>>>> After a "make -f Makefile.osx install" there should be a applebuild
>>>>> folder somewhere, right? Or should it appear only, if I did that via
>>>>> Xcode?
>>>>> Because I don't use Xcode for that. I can't find an applebuild folder. The
>>>>> executable file is located somewhere else in the build folders. I think
>>>>> there is something to do for a cleaner build up in OSX. In Linux it looks
>>>>> nice, except of all these warnings while compiling.
>>>>>
>>>>>
>>>> No not somewhere. applebuild directory should be close to Makefile.osx
>>>> if you ran "make -f Makefile.osx install" in a terminal. And the makefile
>>>> is calling xcodebuild.
>>>> Your patches are welcome but keep in mind MuseScore build system needs
>>>> to run on Linux, Mac and Windows.
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> AlienVault Unified Security Management (USM) platform delivers complete
>>>> security visibility with the essential security capabilities. Easily and
>>>> efficiently configure, manage, and operate all of your security controls
>>>> from a single console and one unified framework. Download a free trial.
>>>> http://p.sf.net/sfu/alienvault_d2d
>>>> _______________________________________________
>>>> Mscore-developer mailing list
>>>> [email protected]
>>>> https://lists.sourceforge.net/lists/listinfo/mscore-developer
>>>>
>>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> AlienVault Unified Security Management (USM) platform delivers complete
>>> security visibility with the essential security capabilities. Easily and
>>> efficiently configure, manage, and operate all of your security controls
>>> from a single console and one unified framework. Download a free trial.
>>> http://p.sf.net/sfu/alienvault_d2d
>>> _______________________________________________
>>> Mscore-developer mailing list
>>> [email protected]
>>> https://lists.sourceforge.net/lists/listinfo/mscore-developer
>>>
>>>
>>
>>
>> ------------------------------------------------------------------------------
>> AlienVault Unified Security Management (USM) platform delivers complete
>> security visibility with the essential security capabilities. Easily and
>> efficiently configure, manage, and operate all of your security controls
>> from a single console and one unified framework. Download a free trial.
>> http://p.sf.net/sfu/alienvault_d2d
>> _______________________________________________
>> Mscore-developer mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/mscore-developer
>>
>>
>
>
> ------------------------------------------------------------------------------
> AlienVault Unified Security Management (USM) platform delivers complete
> security visibility with the essential security capabilities. Easily and
> efficiently configure, manage, and operate all of your security controls
> from a single console and one unified framework. Download a free trial.
> http://p.sf.net/sfu/alienvault_d2d
> _______________________________________________
> Mscore-developer mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mscore-developer
>
>
------------------------------------------------------------------------------
AlienVault Unified Security Management (USM) platform delivers complete
security visibility with the essential security capabilities. Easily and
efficiently configure, manage, and operate all of your security controls
from a single console and one unified framework. Download a free trial.
http://p.sf.net/sfu/alienvault_d2d
_______________________________________________
Mscore-developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
