I also can't respond to anything except question 5, but I also agree that this is a very valuable project.

Sincerely,

Isaac Weiss

On 10/11/17 12:37 AM, David Bolton wrote:
Robbie,

Speaking to question 5, I appreciate what you are doing. Plugins are a great way for people to jump into making MuseScore better who have trouble with C++. Plugins also allow development without having to rebuild the whole source code which lowers lots of barriers. Plugins are great for anyone that wants to develop a small feature that is unique. Sometimes there are features that you want only for a specific project.

David



On 10/10/2017 8:41 PM, Robbie Matthews wrote:

I've been working steadily on the 3.0 plugins, and have reached a point where I'd like some feedback.

Discussion to date: https://musescore.org/en/node/255081

PR to date: https://github.com/musescore/MuseScore/pull/3303

Among other things, I posed the question, do we prefer functions or read only properties?

Specifically, should it be *measure.next* or *measure.next()* ?

jojo-schmidt expressed a preference for functions if they do something, and properties if they don't.

I have a slight preference for that approach myself, so started exposing the .next as a Q_INVOKABLEĀ  (ie, .next()) rather than a read only property.

Score represents a problem, in that a) Score is a QObject, so is exposed directly, as distinct from most other elements, which are wrappered.

Score::firstMeasure() is already used internally, and I can't just Q_INVOKE it because it returns an unwrapped Element*

So it is currently exposed as a read only property, which breaks the pattern I'm trying to estabish.

Question 1: Was the decision to keep Score a QObject critical to development?

Question 2: Should I in any case create a ScoreW to wrap Score and register that with QML? (Starting to think so...)

Question 3: Do others have any strong opinions on .next vs .next() ?

Question 4: Is there anything actually documenting what the various properties do? (for get and set)?

Question 5: Am I wasting my time?

Any input appreciated.

Robbie




_______________________________________________
Mscore-developer mailing list
Mscore-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mscore-developer



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Mscore-developer mailing list
Mscore-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mscore-developer


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Mscore-developer mailing list
Mscore-developer@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mscore-developer

Reply via email to