Hello, while working on MS' OSC implementation I stumbled over several issues/questions:
- The osc code in thirdparty/ofqt has two bugs, one of which causes MS to segfault during program shutdown. For both bugs there are trivial fix in upstream's pull request. How best to proceed? Should I incorporate the fixes into my version and then send a pull request? Or will the core developer team do this. Unfortunately, due to (mostly cosmetic) reformating and commenting out qDebug() calls (why?), the pull requests don't apply cleanly ... - Maybe I miss the obvious, but why are all osc related functions/callbacks declared in musescore/musescore.h ? With such a setup, small changes to the osc code trigger recompilation of substantial parts of musescore. IIUC, those functions are only ever called/used from within osc.cpp. Would you accept a patch that refactors these declarations into osc.h? Cheers, Ralf Mattes ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Mscore-developer mailing list Mscore-developer@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mscore-developer
