I believe the fallthrougj is wanted here and fixed that compiler warning in my PR https://github.com/musescore/MuseScore/pull/3961
---- Tommaso Cucinotta schrieb ---- >Hi, > >while compiling master on Linux, the compiler is warning about two switch >fallthrough, so hinting that this patch may be >needed, anyone can double-check? AFAICS, the code can also be rewritten >removing the switch altogether. Thanks. > >diff --git a/libmscore/pitchspelling.cpp b/libmscore/pitchspelling.cpp >index 544bc4971..9960cbb2b 100644 >--- a/libmscore/pitchspelling.cpp >+++ b/libmscore/pitchspelling.cpp >@@ -684,12 +684,15 @@ void Score::spellNotelist(std::vector<Note*>& notes) > case 3: > k = end - start - 3; > changeAllTpcs(notes[end-3], > tab[(notes[end-3]->pitch() % 12) * 2 + ((opt & (1<<k)) >> k)]); >+ break; > case 2: > k = end - start - 2; > changeAllTpcs(notes[end-2], > tab[(notes[end-2]->pitch() % 12) * 2 + ((opt & (1<<k)) >> k)]); >+ break; > case 1: > k = end - start - 1; > changeAllTpcs(notes[end-1], > tab[(notes[end-1]->pitch() % 12) * 2 + ((opt & (1<<k)) >> k)]); >+ break; > } > break; > > T. >-- >Tommaso Cucinotta >Home Page: http://retis.sssup.it/~tommaso >LinkedIn: http://www.linkedin.com/in/tommasocucinotta > > >_______________________________________________ >Mscore-developer mailing list >Mscore-developer@lists.sourceforge.net >https://lists.sourceforge.net/lists/listinfo/mscore-developer
_______________________________________________ Mscore-developer mailing list Mscore-developer@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mscore-developer
