Hi, On Tue, 8 Jul 2008, Johannes Sixt wrote:
> On Dienstag, 8. Juli 2008, Johannes Schindelin wrote: > > > On Mon, 7 Jul 2008, Johannes Sixt wrote: > > > On Montag, 7. Juli 2008, Johannes Schindelin wrote: > > > > On Mon, 7 Jul 2008, Johannes Sixt wrote: > > > > > Since the 'dash-less' changes are now in upstream, mingw.git > > > > > does not work anymore out of the box. The reason is that I > > > > > introduced a function builtin_exec_path() that computes the path > > > > > from the program invocation and ignores the predefined > > > > > GIT_EXEC_PATH (which is the value of $(gitexecdir) int the > > > > > Makefile). > > > > > > > > What prevents you from stripping "/bin/<basename>.exe" or > > > > "/libexec/git-core/<basename>.exe", whichever was found, from the > > > > path? > > > > > > And use the result as the base to look for templates and > > > ETC_GITCONFIG? What if neither matches? > > > > Well, what do you do at the moment? Let's use that as a fallback, no? > > (I assume that you just strip the last path element.) > > A picture is in order, I think. > > We could derive directories like this: > > [*] [+] > (1) git.exe -----> exec-path -----> templates > |\----> etc/gitconfig > \----> html docs > > or we could do it like this: > > [*] > (2) git.exe ------> exec-path > | [+] > |\-----> templates > |\-----> etc/gitconfig > \-----> html docs > > [*] can be overridden with --exec-path option or GIT_EXEC_PATH env var > [+} can be overridden with --template option GIT_TEMPLATE_DIR env var > > Which one is more appropriate? IMHO 2), since the templates directory and the exec-path directory are same in nature: they are directories with additional stuff. Ciao, Dscho
